masqmail

changeset 267:8be687c06c20

comments (should we really exit failure in this case?) see code
author markus schnalke <meillo@marmaro.de>
date Fri, 03 Dec 2010 11:37:01 -0300
parents ab39047ffe44
children 7b12d081b939
files src/masqmail.c
diffstat 1 files changed, 8 insertions(+), 0 deletions(-) [+]
line diff
     1.1 --- a/src/masqmail.c	Fri Dec 03 11:30:24 2010 -0300
     1.2 +++ b/src/masqmail.c	Fri Dec 03 11:37:01 2010 -0300
     1.3 @@ -263,6 +263,7 @@
     1.4  		exit(1);
     1.5  	}
     1.6  
     1.7 +	/* here the mail is queued and thus in our responsibility */
     1.8  	logwrite(LOG_NOTICE, "%s <= %s with %s\n", msg->uid, addr_string(msg->return_path), prot_names[PROT_LOCAL]);
     1.9  
    1.10  	if (conf.do_queue) {
    1.11 @@ -281,6 +282,13 @@
    1.12  		if (deliver(msg)) {
    1.13  			exit(0);
    1.14  		} else {
    1.15 +			/*
    1.16 +			TODO:
    1.17 +			Should we really fail here? Because the mail is queued
    1.18 +			already. If we fail the client might submit it again.
    1.19 +			If at-once-delivery is seen as an additional best-effort
    1.20 +			service, then we should still exit successful here.
    1.21 +			*/
    1.22  			exit(1);
    1.23  		}
    1.24  	}