# HG changeset patch
# User markus schnalke <meillo@marmaro.de>
# Date 1291387021 10800
# Node ID 8be687c06c20cea215f614f4e7659c5bfda1ef52
# Parent  ab39047ffe44b32291bb90535232bbdfd2bc6279
comments (should we really exit failure in this case?)
see code

diff -r ab39047ffe44 -r 8be687c06c20 src/masqmail.c
--- a/src/masqmail.c	Fri Dec 03 11:30:24 2010 -0300
+++ b/src/masqmail.c	Fri Dec 03 11:37:01 2010 -0300
@@ -263,6 +263,7 @@
 		exit(1);
 	}
 
+	/* here the mail is queued and thus in our responsibility */
 	logwrite(LOG_NOTICE, "%s <= %s with %s\n", msg->uid, addr_string(msg->return_path), prot_names[PROT_LOCAL]);
 
 	if (conf.do_queue) {
@@ -281,6 +282,13 @@
 		if (deliver(msg)) {
 			exit(0);
 		} else {
+			/*
+			TODO:
+			Should we really fail here? Because the mail is queued
+			already. If we fail the client might submit it again.
+			If at-once-delivery is seen as an additional best-effort
+			service, then we should still exit successful here.
+			*/
 			exit(1);
 		}
 	}