Mercurial > masqmail

changeset 267:8be687c06c20

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
comments (should we really exit failure in this case?) see code
author markus schnalke <meillo@marmaro.de>
date Fri, 03 Dec 2010 11:37:01 -0300
parents ab39047ffe44
children 7b12d081b939
files src/masqmail.c
diffstat 1 files changed, 8 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/masqmail.c	Fri Dec 03 11:30:24 2010 -0300
+++ b/src/masqmail.c	Fri Dec 03 11:37:01 2010 -0300
@@ -263,6 +263,7 @@
 		exit(1);
 	}
 
+	/* here the mail is queued and thus in our responsibility */
 	logwrite(LOG_NOTICE, "%s <= %s with %s\n", msg->uid, addr_string(msg->return_path), prot_names[PROT_LOCAL]);
 
 	if (conf.do_queue) {
@@ -281,6 +282,13 @@
 		if (deliver(msg)) {
 			exit(0);
 		} else {
+			/*
+			TODO:
+			Should we really fail here? Because the mail is queued
+			already. If we fail the client might submit it again.
+			If at-once-delivery is seen as an additional best-effort
+			service, then we should still exit successful here.
+			*/
 			exit(1);
 		}
 	}